Review Request 115463: Fix for sending ini and exe files using Google Talk account

Jan Stourac stourac.jan at gmail.com
Tue Feb 4 12:30:13 UTC 2014



> On Feb. 4, 2014, 12:09 p.m., Dan Vrátil wrote:
> > KTp/actions.cpp, line 170
> > <https://git.reviewboard.kde.org/r/115463/diff/1/?file=241751#file241751line170>
> >
> >     I think you need to call the specific constructor overload that takes 3 arguments: suggested filename, content type and file size.
> >     
> >     You should be able to get content type and size from the QFileInfo above.

I used it, but indentation moved it to the very right.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115463/#review48895
-----------------------------------------------------------


On Feb. 4, 2014, 12:01 p.m., Jan Stourac wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115463/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 12:01 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 326786
>     http://bugs.kde.org/show_bug.cgi?id=326786
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> each file transfer is checked for using google talk and forbidden extensions...in that case, "_" character is appended to suggested file name. for all other cases, transfer process remains the same.
> 
> 
> Diffs
> -----
> 
>   KTp/actions.cpp ec8a19e 
> 
> Diff: https://git.reviewboard.kde.org/r/115463/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Stourac
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140204/fb928de7/attachment-0001.html>


More information about the KDE-Telepathy mailing list