Review Request 115425: Activate / deactivate Now Playing globally in KConfig when setting playback status in the contact list

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115425/#review48836
-----------------------------------------------------------


Thanks for the patch.

I'd like to rework this a bit. If you disable it in system settings, let's not show it in the drop down menu in contact list at all. That will be tricky however as we have some hacks in there as you could see, this might use some rework too in fact, but let's focus on the now playing now.

So - disabled in system settings - it hides from the drop down menu completely.

- Martin Klapetek


On Feb. 3, 2014, 4 p.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115425/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 4 p.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Enables / disables Now Playing in systemsettings every time it is enabled / disabled in the contact list.
> 
> Fixes systemsettings kcm showing nowplaying enabled while the contact list has disabled its functionality.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 2047473 
> 
> Diff: https://git.reviewboard.kde.org/r/115425/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140203/34895534/attachment.html>