Review Request 121291: Garbage collect the kded module plugins to prevent stray status messages and presences on shutdown and module restart

[David Edmundson]

> On Nov. 30, 2014, 3:26 p.m., David Edmundson wrote:
> > Why?
> > Isn't this going to result in a tonne of status changes being made whilst we're shutting down?
> 
> James Smith wrote:
>     Yes, but it is effective at keeping stale presences out of the config. #121302 introduces a timer that helps additionally in this situation by waiting an interval before changing the global presence only once instead of multiple times.

We shouldn't be saving presence from the plugins ever anyway. 

That's why StatusHandler::onRequestedPresenceChanged which sets m_lastUserPresence checks if it's a status from a plugin. 

You even wrote the presenceThrottle() code that's in there.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121291/#review71121
-----------------------------------------------------------


On Nov. 30, 2014, 8:46 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121291/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2014, 8:46 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 334492
>     http://bugs.kde.org/show_bug.cgi?id=334492
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> In combination with #120509 , helps during shutdown to prevent session resuming with stale status messages and presences.
> 
> 
> Diffs
> -----
> 
>   telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 
>   autoaway.cpp 4881c71afab2be2468c3c883523d2844865e6247 
>   screensaveraway.cpp f226564a5bf7b396965b5ae21f81d93b7edc3ef8 
> 
> Diff: https://git.reviewboard.kde.org/r/121291/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141210/1fdabfb1/attachment-0001.html>