Review Request 121412: Finish contact list port

[Martin Klapetek]

> On Dec. 9, 2014, 6:03 p.m., Aleix Pol Gonzalez wrote:
> > tooltips/persontooltip.cpp, line 129
> > <https://git.reviewboard.kde.org/r/121412/diff/1/?file=332388#file332388line129>
> >
> >     QString("...") -> QStringLiteral("...")
> >     
> >     Why do we need to construct a new QString to call toHtmlEscaped? It's const.

You mean static? It's not --> http://qt-project.org/doc/qt-5/qstring.html#toHtmlEscaped


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121412/#review71655
-----------------------------------------------------------


On Dec. 9, 2014, 5:59 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121412/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 5:59 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> kdelibs4support free
> 
> 
> Diffs
> -----
> 
>   empty-row-filter.cpp 01b2b48 
>   filter-bar.cpp e912bbf 
>   global-presence-chooser.h e41ae07 
>   global-presence-chooser.cpp ce0c460 
>   ktp-contactlist-debug.h PRE-CREATION 
>   ktp-contactlist-debug.cpp PRE-CREATION 
>   main-widget.h 3ece8a3 
>   CMakeLists.txt 3d25114 
>   account-button.h 19eefb2 
>   account-button.cpp 574b72a 
>   account-buttons-panel.h 3e7f9b6 
>   account-buttons-panel.cpp 7c6712e 
>   contact-delegate-compact.cpp 58196f5 
>   contact-delegate-overlay.h 0357c5d 
>   contact-delegate-overlay.cpp 4b14c5f 
>   contact-delegate.cpp 3c1488d 
>   contact-list-widget.cpp a0fa922 
>   contact-overlays.cpp 62f9bda 
>   contact-view-hover-button.cpp 166d392 
>   context-menu.h bec4e55 
>   context-menu.cpp 2dffd02 
>   dialogs/custom-presence-dialog.h 5b785b0 
>   dialogs/custom-presence-dialog.cpp 67e812d 
>   dialogs/remove-contact-dialog.h 362f069 
>   dialogs/remove-contact-dialog.cpp 2c88887 
>   main-widget.cpp cecfdb0 
>   main-widget.ui 88bac7b 
>   main.cpp 5424ca6 
>   tooltips/contacttooltip.cpp 557a4aa 
>   tooltips/ktooltip.cpp 6e82718 
>   tooltips/ktooltipwindow.cpp f321c24 
>   tooltips/persontooltip.cpp 6b3bb2b 
>   tooltips/tooltipmanager.cpp 2315d35 
> 
> Diff: https://git.reviewboard.kde.org/r/121412/diff/
> 
> 
> Testing
> -------
> 
> It builds, it runs, things seem to work fine
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20141209/7e323e69/attachment.html>