Review Request 119963: Set full screen toggle to off if we exit without clicking it.

[Diane Trout]

> On Aug. 28, 2014, 12:41 a.m., Martin Klapetek wrote:
> > Should this maybe be moved into toggleFullScreen? Some things may be calling that function too without clicking that button...?

Probably. I was hoping there might've been a better way of handling the switch to QML full screen.


- Diane


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119963/#review65397
-----------------------------------------------------------


On Aug. 27, 2014, 9:17 p.m., Diane Trout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119963/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 9:17 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> Toggling the full screen via the menu and then escape previously left the state as checked
> 
> 
> Diffs
> -----
> 
>   src/call-window.cpp 2cbbb7be5cf59a8ad06e11dc2d549b3353fd48f4 
> 
> Diff: https://git.reviewboard.kde.org/r/119963/diff/
> 
> 
> Testing
> -------
> 
> Also I discovered there's a KToggleFullScreenAction which I tried to use, but that seems to want to maximize a traditional qt widget and the qmlUi widget didn't maximize/minimize properly.
> 
> The advantage to the FullScreenAction is it properly sets the icon and description without having to code it. If anyone has a suggestion on how to get KToggleFUllScreenAction to work with the qmlUi widget that would probably be better than this.
> 
> (Oh and I tested by calling myself and toggling the full screen and making sure the check box was off after I hit escape)
> 
> 
> Thanks,
> 
> Diane Trout
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140828/8d28d9ba/attachment.html>