Review Request 119941: Add Accounts KCM Plugin for Telegram
David Edmundson
david at davidedmundson.co.uk
Wed Aug 27 11:24:43 UTC 2014
> On Aug. 27, 2014, 11:22 a.m., Martin Klapetek wrote:
> > plugins/butterfly/butterfly-account-ui.h, line 26
> > <https://git.reviewboard.kde.org/r/119941/diff/1/?file=307672#file307672line26>
> >
> > Why is it called "Morse" and then in the code "Telegram"? That should be consistent
it's like gabble / jabber
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119941/#review65354
-----------------------------------------------------------
On Aug. 26, 2014, 5:02 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119941/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 5:02 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-accounts-kcm
>
>
> Description
> -------
>
> Add Accounts KCM Plugin for Telegram
>
>
> Diffs
> -----
>
> plugins/butterfly/butterfly-account-ui.cpp bacc148
> plugins/butterfly/ktpaccountskcm_plugin_butterfly.desktop.cmake 0be40a3
> plugins/butterfly/main-options-widget.h
> plugins/butterfly/main-options-widget.cpp d787b07
> plugins/butterfly/main-options-widget.ui e3df55b
> plugins/gabble/gabble-account-ui-plugin.h 954a9ed
> plugins/CMakeLists.txt 994fab4
> plugins/butterfly/CMakeLists.txt 1d5d289
> plugins/butterfly/Messages.sh
> plugins/butterfly/butterfly-account-ui-plugin.cpp 25333e4
> plugins/butterfly/butterfly-account-ui.h 1845570
>
> Diff: https://git.reviewboard.kde.org/r/119941/diff/
>
>
> Testing
> -------
>
> Mostly boiler plate, nothing exciting.
>
>
> File Attachments
> ----------------
>
> breeze1.jpg
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/7ae0a7fe-284e-4003-b5b0-e687629ac266__breeze1.jpg
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140827/c23866d9/attachment.html>
More information about the KDE-Telepathy
mailing list