Review Request 119952: Succesfully connect ESC to exitFullScreen

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119952/#review65347
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Aug. 27, 2014, 6:01 a.m., Diane Trout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119952/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 6:01 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> I managed to accomplish this by directly connecting to the QML signals by getting a copy of the QML root object and connecting those signals to the C++ code. Also by directly connecting the signals I was able to remove some of the code to proxy the signals from qml-interface. 
> 
> While I was testing this I found several warning messages about missing signals, for which I at least added stub signals in the QML code to reduce the warnings.
> 
> Also I slightly reindented some of the QML code.
> 
> This is an alternate patch to https://git.reviewboard.kde.org/r/119845/ and includes some of Ovidiu-Florin Bogdan's work.
> 
> 
> Diffs
> -----
> 
>   src/call-window.h 492f7d6 
>   src/call-window.cpp c701130 
>   src/qml-interface.h a129ffc 
>   src/qml-interface.cpp c935768 
>   src/qml/Main.qml 9a59f06 
> 
> Diff: https://git.reviewboard.kde.org/r/119952/diff/
> 
> 
> Testing
> -------
> 
> Compiled called myself via jitsi for android.
> 
> Showed full screen, pressed escape key to exit full screen. (Instead of the previous kill process to exit full screen.
> 
> 
> Thanks,
> 
> Diane Trout
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140827/e652ef78/attachment.html>