Review Request 119880: [frameworks] Port TelepathyHandlerApplication to QApplication

Martin Klapetek martin.klapetek at gmail.com
Mon Aug 25 15:43:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119880/
-----------------------------------------------------------

(Updated Aug. 25, 2014, 5:43 p.m.)


Review request for Telepathy.


Changes
-------

Use QCoreApplication::setApplicationName instead of QApplication::


Repository: ktp-common-internals


Description
-------

KApplication is deprecated with Frameworks, this ports it to QApplication

This also moves the setenv initHack into the applications instantiating the THA, not sure if this would work but a code like

int main(int argc, char *argv[])
{
    setenv("KDE_FULL_SESSION", "true", 0);
    setenv("KDE_SESSION_VERSION", "5", 0);
    
    KTp::TelepathyHandlerApplication app(argc, argv);   
}

should also do the trick I believe.


Diffs (updated)
-----

  KTp/telepathy-handler-application.h 504ad52 
  KTp/telepathy-handler-application.cpp 245ff88 

Diff: https://git.reviewboard.kde.org/r/119880/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140825/f9e49293/attachment-0001.html>


More information about the KDE-Telepathy mailing list