Review Request 119824: Added Notes Plugin

[Nilesh Suthar]

> On Aug. 25, 2014, 3:23 p.m., Martin Klapetek wrote:
> > src/widgets/plugins/note.cpp, lines 53-55
> > <https://git.reviewboard.kde.org/r/119824/diff/1/?file=306114#file306114line53>
> >
> >     --> constructor

layout was defined in createDetailsWidget then how can we use it in the constructor?
It should be here only


- Nilesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119824/#review65176
-----------------------------------------------------------


On Aug. 25, 2014, 7:58 p.m., Nilesh Suthar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119824/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 7:58 p.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Depends on https://git.reviewboard.kde.org/r/119735/ for KABC::Addressee customs
> 
> 
> Diffs
> -----
> 
>   src/widgets/CMakeLists.txt f637838 
>   src/widgets/personnoteview.h PRE-CREATION 
>   src/widgets/personnoteview.cpp PRE-CREATION 
>   src/widgets/plugins/note.h PRE-CREATION 
>   src/widgets/plugins/note.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119824/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nilesh Suthar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140825/728c18fb/attachment.html>