Review Request 119297: Improve MPRIS2 status message plugin to better handle multiple players

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119297/
-----------------------------------------------------------

(Updated Aug. 25, 2014, 11:11 a.m.)


Review request for Telepathy and Martin Klapetek.


Changes
-------

More strict output controls. All information is collected from the player before the status message is set. This improves compatibility with misbehaving players and greatly tidies the plugin's use of the status handler.


Repository: ktp-kded-module


Description
-------

Adds metadata<->player mapping to better keep track of active players and their associated metadata and playback state. This helps with adding and removing of multiple concurrent players while keeping the output fluid and predictable.


Diffs (updated)
-----

  telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
  telepathy-mpris.cpp 44b041fdd3764ee5f67598fcf555a2759d853bdd 

Diff: https://git.reviewboard.kde.org/r/119297/diff/


Testing
-------

Compile, run. Pause / play on multiple players. Close / launch multiple players. Set / unset enabled.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140825/3e06d952/attachment.html>