Review Request 119845: Fix for https://git.reviewboard.kde.org/r/119467/#comment44421

[Ovidiu-Florin Bogdan]

> On Aug. 21, 2014, 8:27 a.m., Martin Klapetek wrote:
> > src/call-window.cpp, lines 424-427
> > <https://git.reviewboard.kde.org/r/119845/diff/2/?file=306750#file306750line424>
> >
> >     This block is confusing, it should either be 
> >     
> >     if () {
> >     } else if () {
> >     } else {}
> >     
> >     OR
> >     
> >     if () {
> >     }
> >     
> >     if () {
> >     
> >     } else {}
> >     
> >     Someone should also investigate why showing dtmf in fullscreen is not working; switching off fullscreen just to show dtmf is not the best

This was also mentioned in https://git.reviewboard.kde.org/r/119467/#comment44391 but there's no comment on how it was resolved.


- Ovidiu-Florin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119845/#review64960
-----------------------------------------------------------


On Aug. 20, 2014, 8:07 p.m., Ovidiu-Florin Bogdan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119845/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 8:07 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> Fix for https://git.reviewboard.kde.org/r/119467/#comment44421
> 
> 
> Diffs
> -----
> 
>   src/call-window.h 492f7d6 
>   src/call-window.cpp ae0bbdb 
> 
> Diff: https://git.reviewboard.kde.org/r/119845/diff/
> 
> 
> Testing
> -------
> 
> Compiled.
> 
> 
> Thanks,
> 
> Ovidiu-Florin Bogdan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140821/46b28515/attachment-0001.html>