Review Request 119880: [frameworks] Port TelepathyHandlerApplication to QApplication

[Martin Klapetek]

> On Aug. 21, 2014, 12:24 p.m., David Edmundson wrote:
> > KTp/telepathy-handler-application.cpp, line 108
> > <https://git.reviewboard.kde.org/r/119880/diff/2/?file=306808#file306808line108>
> >
> >     we still need this right?

I think so; as I explained in the summary, this is now moved to the client apps before constructing THA, that should do the trick too.


> On Aug. 21, 2014, 12:24 p.m., David Edmundson wrote:
> > KTp/telepathy-handler-application.cpp, line 169
> > <https://git.reviewboard.kde.org/r/119880/diff/2/?file=306808#file306808line169>
> >
> >     does this prevent the calling app from having a command line parser?
> >     
> >     (that's a question, I don't know)

I don't think so. (I also don't think any of our components needs another QCLP?)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119880/#review64967
-----------------------------------------------------------


On Aug. 21, 2014, 12:19 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119880/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 12:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> KApplication is deprecated with Frameworks, this ports it to QApplication
> 
> This also moves the setenv initHack into the applications instantiating the THA, not sure if this would work but a code like
> 
> int main(int argc, char *argv[])
> {
>     setenv("KDE_FULL_SESSION", "true", 0);
>     setenv("KDE_SESSION_VERSION", "5", 0);
>     
>     KTp::TelepathyHandlerApplication app(argc, argv);   
> }
> 
> should also do the trick I believe.
> 
> 
> Diffs
> -----
> 
>   KTp/telepathy-handler-application.h 504ad52 
>   KTp/telepathy-handler-application.cpp 245ff88 
> 
> Diff: https://git.reviewboard.kde.org/r/119880/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140821/be1fc3a5/attachment.html>