Review Request 119845: Fix for https://git.reviewboard.kde.org/r/119467/#comment44421

[Diane Trout]

> On Aug. 19, 2014, 11:30 a.m., Diane Trout wrote:
> > I was able to run it and escape doesn't exit full screen.
> > 
> > I suspect this error is applicable.
> > 
> > Object::connect: No such signal QmlInterface::exitFullScreen() in /home/diane/kde/src/master/ktp-call-ui/src/call-window.cpp:622

Also if we just have "toggleFullScreen" it seems a bit weird for escape to toggle fullscreen on and off.


- Diane


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119845/#review64877
-----------------------------------------------------------


On Aug. 19, 2014, 9:49 a.m., Ovidiu-Florin Bogdan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119845/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 9:49 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> Fix for https://git.reviewboard.kde.org/r/119467/#comment44421
> 
> 
> Diffs
> -----
> 
>   src/call-window.h 492f7d6 
>   src/call-window.cpp ae0bbdb 
> 
> Diff: https://git.reviewboard.kde.org/r/119845/diff/
> 
> 
> Testing
> -------
> 
> Compiled.
> 
> 
> Thanks,
> 
> Ovidiu-Florin Bogdan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140819/19f7f3c2/attachment.html>