Review Request 119753: use install(directory and add support for DTMF tones A B C D

[Diane Trout]

> On Aug. 13, 2014, 12:17 a.m., David Edmundson wrote:
> > src/dtmf-qml.cpp, line 48
> > <https://git.reviewboard.kde.org/r/119753/diff/1/?file=304983#file304983line48>
> >
> >     add
> >     
> >      button.length() < 1 {
> >      return;
> >     }
> >     
> >     otherwise we risk crashes here.

What do you think of

if (button.length() != 1 {
   return;
}

On the off chance someone, somehow manages to send a multi-character string to this function.


- Diane


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119753/#review64422
-----------------------------------------------------------


On Aug. 12, 2014, 10:46 p.m., Diane Trout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119753/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 10:46 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> This review contains two commits:
> 
> 1) Use install(directory in CMakeLists.txt
> 2) and add support for DTMF tones A B C D.
> 
> These are small fixes for issues raised in https://git.reviewboard.kde.org/r/119467
> 
> The QChar('A') == button.at(0) test seems a simpler comparison than comparing two QStrings. also that order makes it more robust to typoing =. 
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 4525ebf6f76b6a302950411ceea5f8449bad9e28 
>   src/dtmf-qml.cpp e3a3722994a4529341a153b6467d3271bd2aa591 
> 
> Diff: https://git.reviewboard.kde.org/r/119753/diff/
> 
> 
> Testing
> -------
> 
> Compiled. Launched app. Noticed that I do have a UI (Showing cmake works) and that since I don't have DTMF support in XMPP the DTMF dialpad isn't active. (So no real testing).
> 
> 
> Thanks,
> 
> Diane Trout
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140813/099ebfb5/attachment.html>