Review Request 119722: Added Emails Plugin

[Martin Klapetek]

> On Aug. 12, 2014, 10:54 a.m., Martin Klapetek wrote:
> > src/widgets/plugins/emaillistmodel.cpp, line 39
> > <https://git.reviewboard.kde.org/r/119722/diff/1/?file=303888#file303888line39>
> >
> >     Check if parent is valid and return 0 if not
> 
> Nilesh Suthar wrote:
>     parent index is invalid all the time.

Right as you have a flat-list model, however a good practice is always to check if indexes are valid...so at least keep it in mind ;)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119722/#review64352
-----------------------------------------------------------


On Aug. 12, 2014, 3:29 p.m., Nilesh Suthar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119722/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 3:29 p.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Email are listed in QListview and fetch with the help of baloo
> To be tested with http://quickgit.kde.org/?p=scratch%2Fnileshsuthar%2Fkpeople.git
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b599284 
>   src/widgets/CMakeLists.txt f637838 
>   src/widgets/personemailview.h PRE-CREATION 
>   src/widgets/personemailview.cpp PRE-CREATION 
>   src/widgets/plugins/emaillistmodel.h PRE-CREATION 
>   src/widgets/plugins/emaillistmodel.cpp PRE-CREATION 
>   src/widgets/plugins/emaillistviewdelegate.h PRE-CREATION 
>   src/widgets/plugins/emaillistviewdelegate.cpp PRE-CREATION 
>   src/widgets/plugins/emails.h PRE-CREATION 
>   src/widgets/plugins/emails.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119722/diff/
> 
> 
> Testing
> -------
> 
> Working as needed
> 
> 
> Thanks,
> 
> Nilesh Suthar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140812/0dedd695/attachment-0001.html>