Review Request 116940: Add a new status message plugin class and use it for the now Playing plugin

[Martin Klapetek]

> On Aug. 8, 2014, 2:11 p.m., David Edmundson wrote:
> > status-handler.cpp, line 183
> > <https://git.reviewboard.kde.org/r/116940/diff/20/?file=300640#file300640line183>
> >
> >     I don't get why we're doing this.
> >     
> >     if the plugin is active and it's not the message we currently have, turn the plugin off?
> >     
> >     That's why we have the queue?
> 
> James Smith wrote:
>     This keeps all the status message plugins that aren't actually providing a status message disabled. This behaviour might impact the usefulness of the queue to allow multiple plugins, in the case of the active plugin turning off, to have the next prioritied plugin take over.
> 
> James Smith wrote:
>     The queue is a great thing to have around to determine plugin enabled / active status, and any active plugin's output is also easily retrieved. This function disables all status message plugins when the presence is set to a custom user presence from the contactlist, for instance. In this case, all plugins should be disabled irregardless of the number of plugins. This solution is probably good looking forward, as the least likely to impact multiple-enabled plugin scenarios because the unseen ones are deactivated by default and won't allow plugins to overwrite the active status message if it's also from an active plugin.

> This function disables all status message plugins when the presence is set to a custom user presence from the contactlist

No. We want the auto-away for example to always work, irregardles of what presence the user sets.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116940/#review64058
-----------------------------------------------------------


On Aug. 11, 2014, 2:26 p.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116940/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 2:26 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 332082, 334492 and 334542
>     http://bugs.kde.org/show_bug.cgi?id=332082
>     http://bugs.kde.org/show_bug.cgi?id=334492
>     http://bugs.kde.org/show_bug.cgi?id=334542
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Move status message plugins into a separate class. New infrastructure to help mitigate the occurrence of bug #334492 while using status message plugins: 1) buffering of the last n status messages, and 2) a limiter to help stop flooding the presence changer. Also strips redundant and disused data structures from both classes.
> 
> This patch returns the ability to engage status message plug-ins from custom status messages. Also working is the disabling of non-visible status message plug-ins. State-affinity in the 95% of previously noted cases has been vastly improved also, the few remaining issues should be due to "lite" protocols that don't have a full complement of on-line presences.
> 
> 
> Diffs
> -----
> 
>   telepathy-kded-module-plugin.h 4c161696a706e82059a7eb314773c3644fe26bd7 
>   telepathy-kded-module-plugin.cpp daf73c66947bc946097de7a8e8a1518555131145 
>   telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
>   telepathy-mpris.cpp 44b041fdd3764ee5f67598fcf555a2759d853bdd 
>   CMakeLists.txt 930267740d0bf26f42a48ea55d77148f87df5369 
>   status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff 
>   status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc 
>   telepathy-kded-module-message-plugin.h PRE-CREATION 
>   telepathy-kded-module-message-plugin.cpp PRE-CREATION 
>   tests/CMakeLists.txt 7ec77495417a6790060ea5ea7126c46399dff755 
> 
> Diff: https://git.reviewboard.kde.org/r/116940/diff/
> 
> 
> Testing
> -------
> 
> Disconnect / reconnect, autoconnect / no autoconnect, suspend / resume. Enable / disable via kcm module. Added a new custom presence and engaged the now playing plugin in the contact list from the new presence. Disabled the plugin by activating another presence.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140811/54638a9c/attachment.html>