Review Request 119297: Improve MPRIS2 status message plugin to better handle multiple players

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119297/#review64053
-----------------------------------------------------------



telepathy-mpris.h
<https://git.reviewboard.kde.org/r/119297/#comment44698>

    this name seems backwards.
    
    setPresenceToTrack?



telepathy-mpris.cpp
<https://git.reviewboard.kde.org/r/119297/#comment44692>

    you can't delete this. This means we are watching every single dbus service regardless of whether it's a media player or not.



telepathy-mpris.cpp
<https://git.reviewboard.kde.org/r/119297/#comment44699>

    again, we need this.



telepathy-mpris.cpp
<https://git.reviewboard.kde.org/r/119297/#comment44696>

    Why did this approach not work?
    This seems like it'd do the same thing in a much simpler way than monitoring all players all the time?



telepathy-mpris.cpp
<https://git.reviewboard.kde.org/r/119297/#comment44694>

    this should just be allPlayers.
    
    in general variable names should be nouns not verbs.


- David Edmundson


On Aug. 7, 2014, 12:32 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119297/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 12:32 a.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Adds metadata<->player mapping to better keep track of active players and their associated metadata and playback state. This helps with adding and removing of multiple concurrent players while keeping the output fluid and predictable.
> 
> 
> Diffs
> -----
> 
>   telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
>   telepathy-mpris.cpp 44b041fdd3764ee5f67598fcf555a2759d853bdd 
> 
> Diff: https://git.reviewboard.kde.org/r/119297/diff/
> 
> 
> Testing
> -------
> 
> Compile, run. Pause / play on multiple players. Close / launch multiple players. Set / unset enabled.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140808/d6eef9d8/attachment.html>