Review Request 119636: Added Chat Plugin for KPeople

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119636/#review63970
-----------------------------------------------------------

Ship it!


Nice work, thanks. Give it a day for other people to comment, if there are no comments by tomorrow, ship it!

(also whenever you fix any pointed out issue, there's a "resolved" button next to it, make sure you click all of those to not have a whole bunch of issues left open;)


kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp
<https://git.reviewboard.kde.org/r/119636/#comment44646>

    The qDebug line could have stayed here so that there's at least some hint on why there are no logs


- Martin Klapetek


On Aug. 7, 2014, 11:42 a.m., Nilesh Suthar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119636/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 11:42 a.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Added Chat Plugin for KPeople
> 
> 
> Diffs
> -----
> 
>   kpeople/CMakeLists.txt c5f1019 
>   kpeople/uiplugins/CMakeLists.txt 2fa6b8b 
>   kpeople/uiplugins/chatplugin/CMakeLists.txt PRE-CREATION 
>   kpeople/uiplugins/chatplugin/chatlistviewdelegate.h PRE-CREATION 
>   kpeople/uiplugins/chatplugin/chatlistviewdelegate.cpp PRE-CREATION 
>   kpeople/uiplugins/chatplugin/kpeople_chat_plugin.h PRE-CREATION 
>   kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp PRE-CREATION 
>   kpeople/uiplugins/chatplugin/kpeople_chat_plugin.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119636/diff/
> 
> 
> Testing
> -------
> 
> Both Building fine KPeople and KCI
> 
> 
> Thanks,
> 
> Nilesh Suthar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140807/1e246494/attachment-0001.html>