Review Request 119636: Added Chat Plugin for KPeople

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119636/#review63964
-----------------------------------------------------------


Final round of comments from me, otherwise looks good!


kpeople/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119636/#comment44638>

    Now that I'm looking at this - the chat plugin should be part of the uiplugins/ folder as that's what it is, so let's move it there, you can then just directly copy-paste/append the chatplugin/CMakeLists.txt into uiplugins/CMakeLists.txt



kpeople/chatplugin/chatlistviewdelegate.cpp
<https://git.reviewboard.kde.org/r/119636/#comment44639>

    Variables always start with lowercase, unless they are static/constants



kpeople/chatplugin/chatlistviewdelegate.cpp
<https://git.reviewboard.kde.org/r/119636/#comment44640>

    Same here



kpeople/chatplugin/kpeople_chat_plugin.cpp
<https://git.reviewboard.kde.org/r/119636/#comment44643>

    Delegates need to have a valid parent, when you set it for a view, the view does not take ownership of it, so put either "this" or the view as parent here, otherwise this leaks



kpeople/chatplugin/kpeople_chat_plugin.cpp
<https://git.reviewboard.kde.org/r/119636/#comment44641>

    Return here? There's no point in querying the logs if you have empty dates


- Martin Klapetek


On Aug. 6, 2014, 6:48 p.m., Nilesh Suthar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119636/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 6:48 p.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Added Chat Plugin for KPeople
> 
> 
> Diffs
> -----
> 
>   kpeople/CMakeLists.txt c5f1019 
>   kpeople/chatplugin/CMakeLists.txt PRE-CREATION 
>   kpeople/chatplugin/chatlistviewdelegate.h PRE-CREATION 
>   kpeople/chatplugin/chatlistviewdelegate.cpp PRE-CREATION 
>   kpeople/chatplugin/kpeople_chat_plugin.cpp PRE-CREATION 
>   kpeople/chatplugin/kpeople_chat_plugin.desktop PRE-CREATION 
>   kpeople/chatplugin/kpeople_chat_plugin.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119636/diff/
> 
> 
> Testing
> -------
> 
> Both Building fine KPeople and KCI
> 
> 
> Thanks,
> 
> Nilesh Suthar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140807/eb54f6a4/attachment-0001.html>