Review Request 117916: Implement "search when typing" on the contact list
Renato Atilio
renatoat at gmail.com
Wed Apr 30 21:09:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117916/
-----------------------------------------------------------
Review request for Telepathy.
Bugs: 318591
http://bugs.kde.org/show_bug.cgi?id=318591
Repository: ktp-contact-list
Description
-------
Replace a void action (typing does absolutely nothing currently) by the contact filtering when typing.
What this diff does:
1. Focus the contacts list tree view instead of the status combo box on the contact list opening
2. When searching, focus the contacts list and select the index from keyboardSerch() if valid or first index otherwise - so the user can just type Enter after searching, if needed, to open the chat window
3. When typing on the contacts list, it captures the key events and sends them to the filter bar so it can determine if the event is a text insertion, a backspace or a close request
4. Set the focus on the contacts list after a close request
Diffs
-----
contact-list-widget.h 9aa3a48
contact-list-widget.cpp 49d21ee
filter-bar.h 76dc572
filter-bar.cpp dd57421
main-widget.h aa69daa
main-widget.cpp 27a941d
Diff: https://git.reviewboard.kde.org/r/117916/diff/
Testing
-------
Thanks,
Renato Atilio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140430/ba37eded/attachment-0001.html>
More information about the KDE-Telepathy
mailing list