Review Request 117809: Don't disable input box when disconnected

[Thomas Pfeiffer]

> On April 30, 2014, 11:14 a.m., Martin Klapetek wrote:
> > lib/chat-widget.cpp, line 796
> > <https://git.reviewboard.kde.org/r/117809/diff/2/?file=269499#file269499line796>
> >
> >     "Please try again when the account is online."
> >     
> >     This is a bit weird wording, the account is in user's control; this makes it sound like "oh just wait, the account will eventually be online..somehow".
> >     
> >     Let's change this to "Please connect the account first and then resend".

It depends on whether the account is offline on purpose or not.
I think we should stick to original wording when the requested state is online (meaning that it indeed is not in the user's control), and use "Please connect the account and then try again" ("resend" sounds like it was already sent) when the requested state is offline (and we show the button to go online)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117809/#review56967
-----------------------------------------------------------


On April 29, 2014, 10:58 p.m., Ahmed I. Khalil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117809/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 10:58 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 320385
>     http://bugs.kde.org/show_bug.cgi?id=320385
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Don't disable the input box when disconnected and the user sends a message a status message is added saying "Your message was not sent because you are offline" and the message box is not cleared.
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.h 028ece4 
>   lib/chat-widget.cpp c4f2ea5 
> 
> Diff: https://git.reviewboard.kde.org/r/117809/diff/
> 
> 
> Testing
> -------
> 
> Turned the connection offline, tried to send a message, a status message is added as expected. Then turned the status to online the message is still there and when pressed return the message is sent normally.
> 
> 
> File Attachments
> ----------------
> 
> Message Widget with "Switch Online" button
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/04/29/6139c0a4-c926-4c13-98cb-017fedab3155__Disconnected_with_online_button.png
> Message Widget without the "Switch Online" button
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/04/29/9b46448b-3337-45ff-a336-df1f3ffe125e__Disconnected_with_no_online_button.png
> 
> 
> Thanks,
> 
> Ahmed I. Khalil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140430/ea6d1f9c/attachment.html>