Review Request 117793: Don't hardcode Connection Managers (Haze, Gabble, etc..)

David Edmundson david at davidedmundson.co.uk
Sat Apr 26 18:36:43 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117793/#review56645
-----------------------------------------------------------

Ship it!



tools/debugger/main-window.cpp
<https://git.reviewboard.kde.org/r/117793/#comment39498>

    I'm sure there's an function method so you can just do:
    
    qSort(connectionManagerStringList);
    
    


- David Edmundson


On April 26, 2014, 6:33 p.m., Ahmed I. Khalil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117793/
> -----------------------------------------------------------
> 
> (Updated April 26, 2014, 6:33 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 303563
>     http://bugs.kde.org/show_bug.cgi?id=303563
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Removed the hard coded tabs of Haze, Rakia, Gabble and Salut. And made Only online connection managers to be shown.
> 
> 
> Diffs
> -----
> 
>   tools/debugger/main-window.h 67ea785 
>   tools/debugger/main-window.cpp eb607cc 
>   tools/debugger/main-window.ui dd7dcc4 
> 
> Diff: https://git.reviewboard.kde.org/r/117793/diff/
> 
> 
> Testing
> -------
> 
> Got online with a Jabber account and found only Gabble tab, switched the MSN account to online "Haze" tab is added.
> 
> 
> Thanks,
> 
> Ahmed I. Khalil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140426/6f7ed9d1/attachment.html>


More information about the KDE-Telepathy mailing list