Review Request 117793: Don't hardcode Connection Managers (Haze, Gabble, etc..)
David Edmundson
david at davidedmundson.co.uk
Sat Apr 26 17:52:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117793/#review56640
-----------------------------------------------------------
Ship it!
Woohoo. Cool.
tools/debugger/main-window.cpp
<https://git.reviewboard.kde.org/r/117793/#comment39495>
Maybe turn it into a list and qSort it?
- David Edmundson
On April 26, 2014, 5:45 p.m., Ahmed Ibrahim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117793/
> -----------------------------------------------------------
>
> (Updated April 26, 2014, 5:45 p.m.)
>
>
> Review request for Telepathy.
>
>
> Bugs: 303563
> http://bugs.kde.org/show_bug.cgi?id=303563
>
>
> Repository: ktp-common-internals
>
>
> Description
> -------
>
> Removed the hard coded tabs of Haze, Rakia, Gabble and Salut. And made Only online connection managers to be shown.
>
>
> Diffs
> -----
>
> tools/debugger/main-window.h 67ea785
> tools/debugger/main-window.cpp eb607cc
> tools/debugger/main-window.ui dd7dcc4
>
> Diff: https://git.reviewboard.kde.org/r/117793/diff/
>
>
> Testing
> -------
>
> Got online with a Jabber account and found only Gabble tab, switched the MSN account to online "Haze" tab is added.
>
>
> Thanks,
>
> Ahmed Ibrahim
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140426/634084a3/attachment-0001.html>
More information about the KDE-Telepathy
mailing list