Review Request 117671: Add a filter to hide empty groups as well as fix expansion of metacontacts

Martin Klapetek martin.klapetek at gmail.com
Fri Apr 25 09:19:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117671/#review56488
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Klapetek


On April 25, 2014, 11:03 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117671/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 11:03 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Add a filter to hide empty groups as well as fix expansion of metacontacts
>     
> Remove our rather bad style workaroudn to expand groups with only one
> entry, and instead just filter them out at the model level.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 09061bf 
>   contact-list-widget.cpp 74ad75b 
>   contact-list-widget_p.h e4a5eb3 
>   empty-row-filter.h PRE-CREATION 
>   empty-row-filter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117671/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140425/49bbfcde/attachment.html>


More information about the KDE-Telepathy mailing list