Review Request 117659: Make PersonModel faster

[David Edmundson]

> On April 22, 2014, 8:08 a.m., Martin Klapetek wrote:
> > src/personsmodel.cpp, lines 119-120
> > <https://git.reviewboard.kde.org/r/117659/diff/1/?file=267313#file267313line119>
> >
> >     What's up with this?

david [10:19:15] ~/projects/kde4/src/libkpeople (soo_much_faster)
$ git log 
commit d8f0e5992eaf30eb33e389918bd999919674d837
Author: David Edmundson <kde at davidedmundson.co.uk>
Date:   Sun Apr 20 19:48:45 2014 +0200

    SQUASH THIS: Restore code I commented out like a noob

Fixes this :)
Good review though. Let me update the diff.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117659/#review56164
-----------------------------------------------------------


On April 20, 2014, 5:39 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117659/
> -----------------------------------------------------------
> 
> (Updated April 20, 2014, 5:39 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Make PersonModel faster
> 
> Instead of performing a hash lookup in each data() call, we store MetaContacts in the list and instead use the hash to the index only
> for insertion/deletion.
> 
> 
> Diffs
> -----
> 
>   src/personsmodel.cpp 6a7f9b9 
> 
> Diff: https://git.reviewboard.kde.org/r/117659/diff/
> 
> 
> Testing
> -------
> 
> Merged, unmerged. Checked in callgrind that qHash isn't being abused.
> There's still a few optimisations that could be done, but now PersonsModel isn't the block.
> 
> Cachegrind attached, before on the left.
> 
> 
> File Attachments
> ----------------
> 
> ktp1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/04/20/73f56f9e-469e-4fc7-b28a-bf5dfc39b238__ktp1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140422/dfcdcff9/attachment.html>