Review Request 117671: Add a filter to hide empty groups as well as fix expansion of metacontacts

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117671/#review56160
-----------------------------------------------------------


Is this the "Instead strip this code and re-insert a simple filter at the contact
list level (see patch to contact list)"-patch? How are the rows counted with this then, including the total users count?


contact-list-widget.cpp
<https://git.reviewboard.kde.org/r/117671/#comment39190>

    How does the list look without this?



row-filter.h
<https://git.reviewboard.kde.org/r/117671/#comment39191>

     



row-filter.h
<https://git.reviewboard.kde.org/r/117671/#comment39192>

    Wouldn't just "QSortFilterProxyModel" work?



row-filter.h
<https://git.reviewboard.kde.org/r/117671/#comment39194>

    *parent=0 -> *parent = 0



row-filter.h
<https://git.reviewboard.kde.org/r/117671/#comment39193>

    const QModelIndex& source_parent -> const QModelIndex &source_parent



row-filter.cpp
<https://git.reviewboard.kde.org/r/117671/#comment39195>

     


- Martin Klapetek


On April 21, 2014, 12:36 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117671/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 12:36 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Add a filter to hide empty groups as well as fix expansion of metacontacts
>     
> Remove our rather bad style workaroudn to expand groups with only one
> entry, and instead just filter them out at the model level.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 09061bf 
>   abstract-contact-delegate.cpp a92cc4e 
>   contact-list-widget.cpp 74ad75b 
>   contact-list-widget_p.h e4a5eb3 
>   row-filter.h PRE-CREATION 
>   row-filter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117671/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140422/d4876588/attachment-0001.html>