Review Request 117570: Added join message capability

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117570/#review56086
-----------------------------------------------------------

Ship it!



lib/chat-widget.cpp
<https://git.reviewboard.kde.org/r/117570/#comment39142>

    Ideally try to stick to the same names as Tp uses here: http://telepathy.freedesktop.org/doc/telepathy-qt/a00106.html
    
    it will make it less confusing in the future.



lib/chat-widget.cpp
<https://git.reviewboard.kde.org/r/117570/#comment39141>

    I imagine this gives lots of compiler warnings about unused variables.
    
    Add Q_UNUSED(groupContactsRemoved) to suppress these.


- David Edmundson


On April 20, 2014, 3:59 p.m., Daniel Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117570/
> -----------------------------------------------------------
> 
> (Updated April 20, 2014, 3:59 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Added join message capability. Configuration of displaying it is tied in with the option for showing people leaving.
> 
> 
> Diffs
> -----
> 
>   config/appearance-config-tab.h 9582660 
>   config/appearance-config-tab.cpp f8314d8 
>   config/appearance-config.ui 6440cba 
>   lib/adium-theme-view.h 5eaab55 
>   lib/adium-theme-view.cpp e0ad0b1 
>   lib/chat-widget.h 5428104 
>   lib/chat-widget.cpp 3929e45 
> 
> Diff: https://git.reviewboard.kde.org/r/117570/diff/
> 
> 
> Testing
> -------
> 
> Joined and left with several accounts into a chat room.
> 
> 
> Thanks,
> 
> Daniel Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140420/b80d31dd/attachment.html>