Review Request 117579: Adjust library version number to start with soversion number.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117579/#review55857
-----------------------------------------------------------

Ship it!



CMakeLists.txt
<https://git.reviewboard.kde.org/r/117579/#comment38902>

    oh we still have so version number too, I misunderstood the IRC conversation.
    Do we not want the major version in here too? Will save us having to change it for 1.0.0


Can you do the same for k-c-i too.

- David Edmundson


On April 16, 2014, 4:47 a.m., Diane Trout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117579/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 4:47 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> When submitting libkpeople to debian Sune Vuorela wanted me to adjust library version number so it starts with SONUMBER. The vast majority of shared libraries on Linux conform to the convention that libfoo.so.3 -> libfoo.so.3.4.5. The clearest documenation of the convention I could find was here: http://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html
> 
> I had considered using the pattern libfoo.so.3.$(package_version) AKA something like libfoo.so.3.0.2.1 but 4 digits is also a bit unusual. I decided that its ok if the major package version number and so version number differ as they are referencing different concepts package stability vs API version. However the minor and patch versions would tend to get incremented for the package and the library with roughly the same meaning (minor API compatible changes).
> 
> I can imagine 4 reasonably sane conventions.
> 
> 1) library version number has nothing to do with the product version.
> 2) library version number is soversion+major+minor+patch.
> 3) library version number is soversion+minor+patch.
> 4) library version number is soversion+major+minor.
> 
> My first fix was #2, this version is #3. I don't really care which version works best.
> 
> 
> Diffs
> -----
> 
>   src/widgets/CMakeLists.txt 8be6331 
>   src/CMakeLists.txt a04c332 
>   CMakeLists.txt 5ee7c9d 
> 
> Diff: https://git.reviewboard.kde.org/r/117579/diff/
> 
> 
> Testing
> -------
> 
> Applied patch. mkdir build ; cd build ; cmake .. ; find . -name "*.so" make sure the libkpeople.so.3 -> libkpeople.so.3.2.1
> 
> 
> Thanks,
> 
> Diane Trout
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140416/e3b11218/attachment.html>