Review Request 117541: Restructure Join Chat Dialog

Wed Apr 16 08:26:12 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117541/
-----------------------------------------------------------

(Updated April 16, 2014, 8:26 a.m.)

Review request for Telepathy.

Changes
-------

* fix "if(" -> "if (".
* Call onAccountSelectionChanged before making the accountManager ready. This avoids to show all the favorite rooms until the account mananager is ready.
* Rebase on latest master

Repository: ktp-common-internals

Description
-------

Restructure Join Chat Dialog

Diffs (updated)
-----

  CMakeLists.txt 8d4ea594e967ef7e26eda6b2ac040a314bb34543 
  KTp/Models/rooms-model.h 2ff16043a04bae061f12c5780d22c956e7eced82 
  KTp/Models/rooms-model.cpp 3291b58667d4d5cdfb1acc728dbcb75bc1480e6e 
  KTp/Widgets/join-chat-room-dialog.h 80a1be33758f6d4bc5c2d65855769aa268827d47 
  KTp/Widgets/join-chat-room-dialog.cpp 9d55bd9e59b6640748b1fefb7d03040c37e7d092 
  KTp/Widgets/join-chat-room-dialog.ui ca72088312862d6a1016f15f5da1485633b6cac9 

Diff: https://git.reviewboard.kde.org/r/117541/diff/

Testing
-------

File Attachments
----------------

Previous tab
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/16/1d9c1427-09b1-4e18-89bb-f6e12957d4d7__snapshot147.png
Search tab
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/16/ba5f9862-846c-41bb-8e02-5af8be58c0c8__snapshot148.png

Thanks,

Daniele E. Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140416/606098d9/attachment.html>