Review Request 117543: Don't leave group chat when window is closed

[David Edmundson]

> On April 13, 2014, 4:25 p.m., David Edmundson wrote:
> > app/telepathy-chat-ui.h, line 73
> > <https://git.reviewboard.kde.org/r/117543/diff/3/?file=265230#file265230line73>
> >
> >     I don't see the point of this map.
> >     
> >     if you have a ChatTab you can do tab->channel().
> >     
> >     In the one case where you loop through the values, there's no point it being in a hash. You can just do m_channelaccountMap.value()
> >
> 
> Dan Vrátil wrote:
>     > if you have a ChatTab you can do tab->channel().
>     I can't. In onTabDestroyed() I can use the pointer, because that's handler of QObject::destroyed() signal.
>     
>     > In the one case where you loop through the values, there's no point it being in a hash. You can just do 
>     > m_channelaccountMap.value()
>     I decided to use QHash to improve the lookup time in onGroupChatMessageReceived(), but I can turn it into QMap if you want me to.
>

Then ChatTab could have a signal just before it deletes itself this will save casting and dealing with null pointers.
Or maybe a signal in ChatWindow just before it removes it.

I don't like having a map of ChatTabs that could get out of sync with the actual state. It's messy.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117543/#review55612
-----------------------------------------------------------


On April 13, 2014, 11:23 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117543/
> -----------------------------------------------------------
> 
> (Updated April 13, 2014, 11:23 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> When "Don't leave chat room when window is closed" settings is enabled, the channel is not closed when user closes the tab or window, but is maintained by TelepathyChatUi. The channel can be left via Conversation -> Leave room action.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 72bbd1d 
>   app/chat-window.cpp a7da574 
>   app/telepathy-chat-ui.h 97bc4b7 
>   app/telepathy-chat-ui.cpp 33150b8 
>   config/behavior-config.h d57fd90 
>   config/behavior-config.cpp eeb3597 
>   config/behavior-config.ui c8e731c 
>   lib/chat-widget.cpp 3682742 
>   lib/notify-filter.h f929ce3 
>   lib/notify-filter.cpp 6807dac 
>   lib/text-chat-config.h e0ba24f 
>   lib/text-chat-config.cpp 57c7c0c 
> 
> Diff: https://git.reviewboard.kde.org/r/117543/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140415/7d061df7/attachment.html>