Review Request 117543: Don't leave group chat when window is closed

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117543/#review55821
-----------------------------------------------------------

Ship it!


Looks good to me


app/telepathy-chat-ui.cpp
<https://git.reviewboard.kde.org/r/117543/#comment38877>

    QObject* object -> QObject *object



app/telepathy-chat-ui.cpp
<https://git.reviewboard.kde.org/r/117543/#comment38878>

    Remove? Doesn't seem to be too useful (as well as others a bit down)



app/telepathy-chat-ui.cpp
<https://git.reviewboard.kde.org/r/117543/#comment38879>

    Tp::ReceivedMessage& message -> Tp::ReceivedMessage &message


- Martin Klapetek


On April 14, 2014, 1:23 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117543/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 1:23 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> When "Don't leave chat room when window is closed" settings is enabled, the channel is not closed when user closes the tab or window, but is maintained by TelepathyChatUi. The channel can be left via Conversation -> Leave room action.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 72bbd1d 
>   app/chat-window.cpp a7da574 
>   app/telepathy-chat-ui.h 97bc4b7 
>   app/telepathy-chat-ui.cpp 33150b8 
>   config/behavior-config.h d57fd90 
>   config/behavior-config.cpp eeb3597 
>   config/behavior-config.ui c8e731c 
>   lib/chat-widget.cpp 3682742 
>   lib/notify-filter.h f929ce3 
>   lib/notify-filter.cpp 6807dac 
>   lib/text-chat-config.h e0ba24f 
>   lib/text-chat-config.cpp 57c7c0c 
> 
> Diff: https://git.reviewboard.kde.org/r/117543/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140415/3eb6464d/attachment.html>