Review Request 117573: When dragging an image over the text-ui the image is uploaded to one of the image sharing services that the image-sharer library supports (Imgur, ImageBin and Simplest Image Hosting).

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117573/#review55781
-----------------------------------------------------------



lib/chat-widget.cpp
<https://git.reviewboard.kde.org/r/117573/#comment38809>

    I'd quite like to have a menu appear when you drop the image, like when you drag and drop in Dolphin
    
    This way people can use file transfer when applicable and it will prevent sending a file if you drop by accident (I've done this enough times to know it's a real problem)



lib/chat-widget.cpp
<https://git.reviewboard.kde.org/r/117573/#comment38808>

    That isn't a sensible approach. If I start typing to someone and then the upload finishes I'll have my half written message sent.
    
    we can just call the send on the textChannel and leave the messageBox alone


- David Edmundson


On April 14, 2014, 11:18 p.m., Ahmed Ibrahim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117573/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 11:18 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Bugs: 322874
>     http://bugs.kde.org/show_bug.cgi?id=322874
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> I've wrote an extensible image sharer library that can upload images to Imgur, Simplest Image Host and ImageBin, the library can be extended to support other services like wstaw.org for example. I've integrated the library with text-ui and used it to share images to the choosed service when dragging it to the text-ui. 
> 
> I've added a new "Image Sharing" configuration item under the Chat Tab Behaviour, you will find the screenshot attached.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt eabecd9 
>   config/CMakeLists.txt a8e7cd9 
>   config/behavior-config.h d57fd90 
>   config/behavior-config.cpp eeb3597 
>   config/behavior-config.ui c8e731c 
>   image-sharer/CMakeLists.txt PRE-CREATION 
>   image-sharer/abstractsharer.h PRE-CREATION 
>   image-sharer/abstractsharer.cpp PRE-CREATION 
>   image-sharer/cmake/CMakeLists.txt PRE-CREATION 
>   image-sharer/cmake/modules/FindQJson.cmake PRE-CREATION 
>   image-sharer/imagebinsharer.h PRE-CREATION 
>   image-sharer/imagebinsharer.cpp PRE-CREATION 
>   image-sharer/imagesharer_export.h PRE-CREATION 
>   image-sharer/imgursharer.h PRE-CREATION 
>   image-sharer/imgursharer.cpp PRE-CREATION 
>   image-sharer/mpform.h PRE-CREATION 
>   image-sharer/mpform.cpp PRE-CREATION 
>   image-sharer/shareprovider.h PRE-CREATION 
>   image-sharer/shareprovider.cpp PRE-CREATION 
>   image-sharer/simplestimagehostingsharer.h PRE-CREATION 
>   image-sharer/simplestimagehostingsharer.cpp PRE-CREATION 
>   lib/CMakeLists.txt d640536 
>   lib/chat-widget.h d9c4e60 
>   lib/chat-widget.cpp d130529 
>   lib/text-chat-config.h e0ba24f 
>   lib/text-chat-config.cpp 57c7c0c 
> 
> Diff: https://git.reviewboard.kde.org/r/117573/diff/
> 
> 
> Testing
> -------
> 
> Dragged an image to the text-ui and the image url is appended and sent to the other endpoint of the conversation.
> 
> 
> File Attachments
> ----------------
> 
> A screenshot of an uploaded image to the three supported image sharing services 
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/04/14/1a00a5d6-dd2e-4b58-a25b-c456d4adc89e__ktp-text-ui-share.png
> Image Sharing Settings under the Chat Tab Behaviour
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/04/14/546bdac8-a803-48ac-a79c-0b5a8ba2a392__snapshot4.png
> 
> 
> Thanks,
> 
> Ahmed Ibrahim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140414/32d28528/attachment.html>