Review Request 117545: Improve usability of the GlobalPresence QtQuick bindings

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117545/#review55621
-----------------------------------------------------------


This review has been submitted with commit ee4c6120e006c5adda8fdf2d4390f0cb9f62ff9d by Aleix Pol to branch master.

- Commit Hook


On April 13, 2014, 3:42 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117545/
> -----------------------------------------------------------
> 
> (Updated April 13, 2014, 3:42 p.m.)
> 
> 
> Review request for Telepathy and Siddhartha Sahu.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Notifies about presence changes when presence changes.
> Exposes the icon so that it can be displayed on UI, Tp::Presence is not a QObject so it can't be introspected.
> Name the QtQuick binding the same way as the class name, otherwise it's confusing.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/qml-plugins.cpp ce5e165 
>   KTp/global-presence.h 226bed1 
>   KTp/global-presence.cpp f7f1c95 
> 
> Diff: https://git.reviewboard.kde.org/r/117545/diff/
> 
> 
> Testing
> -------
> 
> The contact list plasmoid now displays the status.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140413/b364d6fd/attachment.html>