Review Request 117547: Save 1/0 instead of true/false for boolean tags in plist files

David Edmundson david at davidedmundson.co.uk
Sun Apr 13 16:40:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117547/#review55620
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On April 13, 2014, 4:38 p.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117547/
> -----------------------------------------------------------
> 
> (Updated April 13, 2014, 4:38 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Save 1/0 instead of true/false for boolean tags in plist files
> 
> Also make the check case insensitive
> 
> This fixes a couple of themes using a bool for "MessageViewVersion"
> 
> 
> Diffs
> -----
> 
>   lib/chat-style-plist-file-reader.cpp 9d6e8d4ee619c3d0f4e54f19414e4e8ba87289b5 
> 
> Diff: https://git.reviewboard.kde.org/r/117547/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140413/acc29b49/attachment.html>


More information about the KDE-Telepathy mailing list