Review Request 117543: Don't leave group chat when window is closed

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117543/#review55612
-----------------------------------------------------------



app/telepathy-chat-ui.h
<https://git.reviewboard.kde.org/r/117543/#comment38698>

    I don't see the point of this map.
    
    if you have a ChatTab you can do tab->channel().
    
    In the one case where you loop through the values, there's no point it being in a hash. You can just do m_channelaccountMap.value()
    



app/telepathy-chat-ui.cpp
<https://git.reviewboard.kde.org/r/117543/#comment38704>

    ChatWindow has a getTab(account, contact) method
    
    Or you can do m_channelAccountMap.contains(channel);
    
    



config/behavior-config.ui
<https://git.reviewboard.kde.org/r/117543/#comment38690>

    I think it's generally bad to have a checkbox label which is phrased in negative.
    
    


- David Edmundson


On April 13, 2014, 2:53 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117543/
> -----------------------------------------------------------
> 
> (Updated April 13, 2014, 2:53 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> When "Don't leave chat room when window is closed" settings is enabled, the channel is not closed when user closes the tab or window, but is maintained by TelepathyChatUi. The channel can be left via Conversation -> Leave room action.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 72bbd1d 
>   app/chat-window.cpp a7da574 
>   app/telepathy-chat-ui.h 97bc4b7 
>   app/telepathy-chat-ui.cpp 33150b8 
>   config/behavior-config.h d57fd90 
>   config/behavior-config.cpp eeb3597 
>   config/behavior-config.ui c8e731c 
>   lib/chat-widget.cpp 3682742 
>   lib/notify-filter.h f929ce3 
>   lib/notify-filter.cpp 6807dac 
>   lib/text-chat-config.h e0ba24f 
>   lib/text-chat-config.cpp 57c7c0c 
> 
> Diff: https://git.reviewboard.kde.org/r/117543/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140413/b746f9d2/attachment.html>