Review Request 113448: Split Message Handling out of text-ui into a new class ready for QML drop in later

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113448/#review55613
-----------------------------------------------------------


Overall looks good, +1


lib/chat-widget.cpp
<https://git.reviewboard.kde.org/r/113448/#comment38691>

    > //tell Tp we are no longer want to
    
    s/are//



lib/message-view.h
<https://git.reviewboard.kde.org/r/113448/#comment38692>

     



lib/message-view.h
<https://git.reviewboard.kde.org/r/113448/#comment38693>

    Is this comment any useful here? Looks like it will not be true anymore soon



lib/message-view.h
<https://git.reviewboard.kde.org/r/113448/#comment38694>

    Tp::ReceivedMessage& message --> Tp::ReceivedMessage &message



lib/message-view.cpp
<https://git.reviewboard.kde.org/r/113448/#comment38695>

    Will this break the current behavior?



lib/message-view.cpp
<https://git.reviewboard.kde.org/r/113448/#comment38696>

    Why this->?



lib/message-view.cpp
<https://git.reviewboard.kde.org/r/113448/#comment38697>

    The comment should be in the "else" part, no?



lib/message-view.cpp
<https://git.reviewboard.kde.org/r/113448/#comment38699>

    Kill this...?



lib/message-view.cpp
<https://git.reviewboard.kde.org/r/113448/#comment38700>

    Tp::ReceivedMessage& message -> Tp::ReceivedMessage &message



lib/message-view.cpp
<https://git.reviewboard.kde.org/r/113448/#comment38701>

    str.channel()aight --> str.channel() right



lib/message-view.cpp
<https://git.reviewboard.kde.org/r/113448/#comment38702>

    &s -> right



lib/message-view.cpp
<https://git.reviewboard.kde.org/r/113448/#comment38703>

    & -> right



logviewer/message-view.cpp
<https://git.reviewboard.kde.org/r/113448/#comment38705>

    If you're changing this line already...you know what my comment will be ;)


- Martin Klapetek


On Nov. 7, 2013, 12:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113448/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 12:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> commit 655de06f7d218109f365bdbeed4c567b63e45376
> Author: David Edmundson <kde at davidedmundson.co.uk>
> Date:   Mon Oct 14 14:14:44 2013 -0700
> 
>     Fix notifications
> 
> commit 28a6ed3b5adcd82449d4e2ee58717ce6b0a27d78
> Author: David Edmundson <kde at davidedmundson.co.uk>
> Date:   Mon Oct 14 18:47:29 2013 +0000
> 
>     Split message handling out of ChatWidget into MessageView
>     
>     This prepares it ready for moving to the QML message view
> 
> commit 77897b72c6c5ef3a9d4d0c3753b7796cdf24768f
> Author: David Edmundson <kde at davidedmundson.co.uk>
> Date:   Mon Oct 14 18:46:53 2013 +0000
> 
>     Rename MessageView -> LogMessageView
>     
>     (it conflicts with a new class I'm about to add)
> 
> 
> Diffs
> -----
> 
>   lib/message-view.cpp PRE-CREATION 
>   lib/chat-widget.ui 0985f9c 
>   lib/message-view.h PRE-CREATION 
>   lib/chat-widget.cpp cf8b509 
>   lib/CMakeLists.txt 5706522 
>   lib/chat-widget.h c1dbd41 
>   lib/notify-filter.h f929ce3 
>   lib/notify-filter.cpp a5c8ba0 
>   logviewer/CMakeLists.txt 74989d4 
>   logviewer/config/behavior-config.cpp 247c03a 
>   logviewer/log-viewer.ui cb0a313 
>   logviewer/message-view.h ec592c7 
>   logviewer/message-view.cpp 0b137e1 
> 
> Diff: https://git.reviewboard.kde.org/r/113448/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140413/8f767051/attachment-0001.html>