Review Request 117534: Don't terminate TelepathyHandlerApplication in persistent mode when last window is closed

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117534/
-----------------------------------------------------------

(Updated April 13, 2014, 4:17 p.m.)


Status
------

This change has been discarded.


Review request for Telepathy.


Repository: ktp-common-internals


Description
-------

This patch adds persist bool argument to ctors of TelepathyHandlerApplication, which allows applications to force the persistent mode (like passing --persist to command line). This is needed for ktp-text-ui in order to stay alive and keep group chats channels opened even when all windows are closed.

Secondly, this patch makes THA actually persist even when last window is closed. This is because each KMainWindow holds one KGlobal reference and KGlobal::deref() will call QApplication::quit() regardless of setQuitOnLastWindowClosed(). To prevent this from happening, THA is now holding one reference indefinitely, which means that the application can only be terminated by an explicit call to QApplication::quit() from the application itself.


Diffs
-----

  KTp/telepathy-handler-application.h fbdb523 
  KTp/telepathy-handler-application.cpp 2b5d608 

Diff: https://git.reviewboard.kde.org/r/117534/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140413/29bfe390/attachment.html>