Review Request 117541: Restructure Join Chat Dialog

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117541/#review55593
-----------------------------------------------------------



KTp/Models/rooms-model.cpp
<https://git.reviewboard.kde.org/r/117541/#comment38685>

    This is dangerous.
    
    on an already empty list you would do
    
    beginRemoveRows(0,-1)
    
    
    use beginReset maybe


- David Edmundson


On April 13, 2014, 1:34 p.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117541/
> -----------------------------------------------------------
> 
> (Updated April 13, 2014, 1:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Restructure Join Chat Dialog
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8d4ea594e967ef7e26eda6b2ac040a314bb34543 
>   KTp/Models/rooms-model.h 2ff16043a04bae061f12c5780d22c956e7eced82 
>   KTp/Models/rooms-model.cpp 3291b58667d4d5cdfb1acc728dbcb75bc1480e6e 
>   KTp/Widgets/join-chat-room-dialog.h 1b69f25fee81dbc9aa7f2d380d7c61783e9a951f 
>   KTp/Widgets/join-chat-room-dialog.cpp 710eb87e873527e5d9571b904d78aaefa72fa49d 
>   KTp/Widgets/join-chat-room-dialog.ui 058362d967ddf1429a88d7867aefb971dbd72b77 
> 
> Diff: https://git.reviewboard.kde.org/r/117541/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140413/eda40bbc/attachment.html>