Review Request 117500: Presence and Join/Leave messages in chat

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117500/#review55464
-----------------------------------------------------------



config/appearance-config-tab.h
<https://git.reviewboard.kde.org/r/117500/#comment38604>

    This is really a nitpick but...should we rename this given there are no "join" changes? Except for IRC maybe but we're not supporting that anyway...



config/appearance-config-tab.cpp
<https://git.reviewboard.kde.org/r/117500/#comment38605>

    This should use SIGNAL(toggled(bool)) (I know you're copying the line above but let's not copy wrong code :) Can you please change both lines again?)



config/appearance-config-tab.cpp
<https://git.reviewboard.kde.org/r/117500/#comment38606>

    ...if you change the slot signature, then you can just pass the bool directly to setShowLeaveChanges(..)



config/appearance-config-tab.cpp
<https://git.reviewboard.kde.org/r/117500/#comment38607>

    Here you can do 
    
    ui->showPresenceCheckBox->setChecked(!m_groupChat);
    
    to keep the same style as above but that's up to you


- Martin Klapetek


On April 11, 2014, 3:07 p.m., Daniel Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117500/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 3:07 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Added leave message visibility checkbox.
> 
> Presence and leave are both on by default in normal chats and off in group chats.
> 
> 
> Diffs
> -----
> 
>   config/appearance-config-tab.h 9f3022f 
>   config/appearance-config-tab.cpp 1e2666a 
>   config/appearance-config.ui 52ecfed 
>   lib/adium-theme-view.h 3ec51b2 
>   lib/adium-theme-view.cpp d804177 
>   lib/chat-widget.cpp 0bf369b 
> 
> Diff: https://git.reviewboard.kde.org/r/117500/diff/
> 
> 
> Testing
> -------
> 
> enabling/disable display of messages in normal and group chats.
> 
> 
> Thanks,
> 
> Daniel Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140411/5b14eb18/attachment.html>