Review Request 117500: Presence and Join/Leave messages in chat

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117500/#review55452
-----------------------------------------------------------



config/appearance-config-tab.cpp
<https://git.reviewboard.kde.org/r/117500/#comment38593>

    Not your code, but why are we i18ning "Jabber"? :O



config/appearance-config.ui
<https://git.reviewboard.kde.org/r/117500/#comment38591>

    Can we possibly think of a better string for this? This will tell nothing to normal users, so we should reword this so that even non-tech savvy users can understand this
    
    "Show when contacts join/leave chat"?



config/appearance-config.ui
<https://git.reviewboard.kde.org/r/117500/#comment38592>

    What's this about?


- Martin Klapetek


On April 11, 2014, 2:31 p.m., Daniel Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117500/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 2:31 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Added join/leave message visibility checkbox.
> 
> Presence and join/leave are both on by default in normal chats and off in group chats.
> 
> 
> Diffs
> -----
> 
>   config/appearance-config-tab.h 9f3022f 
>   config/appearance-config-tab.cpp 1e2666a 
>   config/appearance-config.ui 52ecfed 
>   lib/CMakeLists.txt d640536 
>   lib/Messages.sh 7ed3b90 
>   lib/adium-theme-content-info.h 8adb2ed 
>   lib/adium-theme-content-info.cpp 08945d4 
>   lib/adium-theme-header-info.h 177d699 
>   lib/adium-theme-header-info.cpp 3dfa249 
>   lib/adium-theme-message-info.h 35ead23 
>   lib/adium-theme-message-info.cpp 7726fd2 
>   lib/adium-theme-status-info.h 1cafbe5 
>   lib/adium-theme-status-info.cpp 7ab7513 
>   lib/adium-theme-view.h 3ec51b2 
>   lib/adium-theme-view.cpp d804177 
>   lib/channel-contact-model.h b03346b 
>   lib/channel-contact-model.cpp c2d7a80 
>   lib/chat-search-bar.h 58f7a1a 
>   lib/chat-search-bar.cpp d5ccdf5 
>   lib/chat-style-plist-file-reader.h c30c6dd 
>   lib/chat-style-plist-file-reader.cpp 9d6e8d4 
>   lib/chat-text-edit.h bc3720e 
>   lib/chat-text-edit.cpp 517e3e1 
>   lib/chat-widget.h f2fbd3b 
>   lib/chat-widget.cpp 0bf369b 
>   lib/chat-widget.ui 0985f9c 
>   lib/chat-window-style-manager.h 3e38022 
>   lib/chat-window-style-manager.cpp f63ea6f 
>   lib/chat-window-style.h 6a72cb1 
>   lib/chat-window-style.cpp 9a75237 
>   lib/ktpchat_export.h ee6bcc3 
>   lib/ktptxtui_message_filter.desktop 14fb104 
>   lib/notify-filter.h f929ce3 
>   lib/notify-filter.cpp 6807dac 
>   lib/text-chat-config.h e0ba24f 
>   lib/text-chat-config.cpp 57c7c0c 
> 
> Diff: https://git.reviewboard.kde.org/r/117500/diff/
> 
> 
> Testing
> -------
> 
> enabling/disable display of messages in normal and group chats.
> 
> 
> Thanks,
> 
> Daniel Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140411/90e6515e/attachment-0001.html>