Review Request 115993: Show current presence and status message in contact list titlebar

James Smith smithjd15 at gmail.com
Wed Apr 9 07:15:05 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115993/
-----------------------------------------------------------

(Updated April 9, 2014, 7:15 a.m.)


Review request for Telepathy.


Changes
-------

Use currentPresenceChanged() to avoid account off-lining issues with requestedPresenceChanged() . Use KWindowInfo to return the window title. Only use status message not presence and status message when there is a status message set. 


Repository: ktp-contact-list


Description
-------

Shows the current presence in the contact list titlebar.


Diffs (updated)
-----

  main-widget.cpp 3e3950d 
  main-widget.h 11efbeb 

Diff: https://git.reviewboard.kde.org/r/115993/diff/


Testing
-------

Compile, run


File Attachments
----------------

With no status message
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/07/d60c670d-5414-4242-8d14-441b1b553c9f__titlebarrequestedpresencenostatusmessage.png
With status message
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/07/628383dd-1d02-4e03-b67d-b2297d558324__titlebarrequestedpresencestatusmessage.png


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140409/503c4df9/attachment.html>


More information about the KDE-Telepathy mailing list