Review Request 117181: Use SettingsKcmDialog from K-C-I
David Edmundson
david at davidedmundson.co.uk
Sun Apr 6 12:06:35 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117181/#review55064
-----------------------------------------------------------
Ship it!
presence/src/presence-applet.cpp
<https://git.reviewboard.kde.org/r/117181/#comment38406>
Maybe this resize should be in the SettingsKcmDialog?
- David Edmundson
On April 2, 2014, 3:59 p.m., Siddhartha Sahu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117181/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 3:59 p.m.)
>
>
> Review request for Telepathy.
>
>
> Bugs: 326998
> http://bugs.kde.org/show_bug.cgi?id=326998
>
>
> Repository: ktp-desktop-applets
>
>
> Description
> -------
>
> Ported from ktp-contact-list's contact-list-widget.cpp
>
>
> Diffs
> -----
>
> presence/src/presence-applet.h e090f795222a582aa68203b9a5bd8e94fc968963
> presence/src/presence-applet.cpp 188707068114ba5b8d97aec5d8f38fff573afb01
>
> Diff: https://git.reviewboard.kde.org/r/117181/diff/
>
>
> Testing
> -------
>
> Settings dialog successfully opens
>
>
> Thanks,
>
> Siddhartha Sahu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140406/20e7a0b7/attachment.html>
More information about the KDE-Telepathy
mailing list