Review Request 116880: Add PresenceManager class for use from QML

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116880/#review55063
-----------------------------------------------------------

Ship it!


Ship it, but I might have a go at squashing this code into GlobalPresence at some point in the future.


KTp/Declarative/presence-manager.h
<https://git.reviewboard.kde.org/r/116880/#comment38405>

    This isn't the best signal name. As it implies one single account is ready.
    Does anything actually use this? Either rename or delete it.


- David Edmundson


On April 3, 2014, 10:08 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116880/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 10:08 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> This adds a PresenceManager class to Declarative code that can be used from QML to get and set global presence.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/CMakeLists.txt 57025536af43279d31380f32a2827e4060686fdc 
>   KTp/Declarative/qml-plugins.cpp bc134e0dcb35ebd323dee5164a8ce5ae5537dd75 
>   KTp/Declarative/presence-manager.cpp PRE-CREATION 
>   KTp/Declarative/presence-manager.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116880/diff/
> 
> 
> Testing
> -------
> 
> Is accessible from ktp-active, functions called successfully with parameters
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140406/dc1e7c10/attachment.html>