Review Request 117329: Split presence handling into a new class and add easier way to test.
Martin Klapetek
martin.klapetek at gmail.com
Wed Apr 2 12:23:05 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117329/#review54872
-----------------------------------------------------------
Ship it!
telepathy-module.cpp
<https://git.reviewboard.kde.org/r/117329/#comment38321>
This should be retained in the pasted file
- Martin Klapetek
On April 2, 2014, 1:08 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117329/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 1:08 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-kded-module
>
>
> Description
> -------
>
> Split presence handling into a new class. Code is a direct copy/paste from telepathy-module (changes to that should happen in later commits)
>
> Add small app for running the status handling of the kded
> Rather than restarting kded all the time developers can run the small test app to check the status handling.
>
>
> Should be possible to turn this into a proper unit test at some point in the near future later.
>
>
> Diffs
> -----
>
> CMakeLists.txt d08606b
> status-handler.h PRE-CREATION
> status-handler.cpp PRE-CREATION
> telepathy-module.h 2213cdf
> telepathy-module.cpp 030a0d9
> tests/CMakeLists.txt 7696369
> tests/status-handling-main.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/117329/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140402/38bb77cd/attachment.html>
More information about the KDE-Telepathy
mailing list