Review Request 112970: Save uniqueIdentifier instead of objectPath

[David Edmundson]

> On Sept. 28, 2013, 12:06 a.m., David Edmundson wrote:
> > ++ will be very useful when going to mission-control-6 where the object path changes.
> > 
> > I'm curious as to what will happen when we migrate - I'm going to apply this here and see if anything breaks.
> > If it doesn't, you'll get a ship it! If it does break.. you'll be in trouble.

It deleted all the old contacts because the account had been "deleted" (the old object path, didn't match the new unique path). Then it re-fed everything.

No risk of corrupt databases due to this.

It does mean this patch will wipe all user's existing metacontacts. I think as we're in beta that's fine but put a note in the commit message saying this will happen and CC the ML.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112970/#review40928
-----------------------------------------------------------


On Sept. 27, 2013, 11:52 p.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112970/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 11:52 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> uniqueIdentifier is guaranteed to be unique by telepathy, object paths coming from different service could hypotetically be non-unique, even though I believe that the specs require to append the uniqueIdentifier to "/org/freedesktop/Telepathy/"... anyway it is shorter and since it is the value returned as "account" from kpeople query, I believe it should be the same value saved in ~/.local/share/telepathy/mission-control/accounts.cfg
> 
> 
> Diffs
> -----
> 
>   KTp/Models/accounts-tree-proxy-model.cpp c6002948093a22ecff9149651d41a030df838aa3 
>   kpeople/nepomuk-feeder/account.cpp 161ea40ae609165a609a545b08a8d202dad07c1c 
>   kpeople/nepomuk-feeder/controller.cpp fa37b7e01734a2066261c3950d03f13ea034c02f 
> 
> Diff: http://git.reviewboard.kde.org/r/112970/diff/
> 
> 
> Testing
> -------
> 
> Switched a few times from objectPath to uniqueIdentifier, contacts are updated (tested with nepomuk shell), contact list still works
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130928/a14539e2/attachment-0001.html>