Review Request 112886: Remove contacts from Nepomuk when removed from Tp.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112886/#review40502
-----------------------------------------------------------

Ship it!



kpeople/nepomuk-feeder/account.cpp
<http://git.reviewboard.kde.org/r/112886/#comment29816>

    Tp::ContactPtr& contact -> Tp::ContactPtr &contact



kpeople/nepomuk-feeder/nepomuk-storage.cpp
<http://git.reviewboard.kde.org/r/112886/#comment29815>

    QString& path -> QString &path, same with contact


- Martin Klapetek


On Sept. 23, 2013, 1:57 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112886/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2013, 1:57 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Remove contacts from Nepomuk when removed from Tp.
> 
> Also fix adding contacts not being added immediately after using "addContact"
> (missing signal/slot connection).
> 
> 
> This addresses bug 325065.
>     http://bugs.kde.org/show_bug.cgi?id=325065
> 
> 
> Diffs
> -----
> 
>   kpeople/nepomuk-feeder/nepomuk-storage.cpp 47a7ea8e39f4547f93d6d4d3e5b7ce5d6bbd5ac5 
>   kpeople/nepomuk-feeder/nepomuk-storage.h 237b19d5b536801dfa25a8db45355d5d32a6d4d2 
>   kpeople/nepomuk-feeder/controller.cpp 427031329a7eac0ff59c3d9ef7395a2ac77130de 
>   kpeople/nepomuk-feeder/account.cpp e5ee06fa863fc4676fcbbbd6ce339d29f1e8fde1 
>   kpeople/nepomuk-feeder/account.h 8389d0f0f614eb2831d9257c69ad9f9df7f20674 
>   kpeople/nepomuk-feeder/abstract-storage.h 5b93df2163fee0cc3b394bb9240f71a824fff005 
> 
> Diff: http://git.reviewboard.kde.org/r/112886/diff/
> 
> 
> Testing
> -------
> 
> Added/removed lots of people \o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130923/a81edbaa/attachment-0001.html>