Review Request 112887: Simplify model index looping in AbstractGroupingProxyModel::onDataChanged();

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112887/#review40501
-----------------------------------------------------------

Ship it!



KTp/Models/abstract-grouping-proxy-model.cpp
<http://git.reviewboard.kde.org/r/112887/#comment29814>

    Just a thought, if something is emitting dataChanged(..) with invalid indexes, we should find out what and why...


- Martin Klapetek


On Sept. 23, 2013, 2:46 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112887/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2013, 2:46 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Simplify model index looping in AbstractGroupingProxyModel::onDataChanged();
> 
> I think there's a good chance this will fix that crash on startup we've seen.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/abstract-grouping-proxy-model.cpp e85d4171871f5c84dba8a5be0d1fa5e2a8990294 
> 
> Diff: http://git.reviewboard.kde.org/r/112887/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130923/e975608e/attachment.html>