Review Request 110739: Create and cache the contact groups

Commit Hook null at kde.org
Sun Sep 22 13:57:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110739/#review40471
-----------------------------------------------------------


This review has been submitted with commit 024f2046c462150c818121d9cf96173cea495959 by David Edmundson on behalf of Vishesh Handa to branch nepomuk-feeder.

- Commit Hook


On June 3, 2013, 11:16 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110739/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 11:16 a.m.)
> 
> 
> Review request for Telepathy, Aleix Pol Gonzalez, David Edmundson, and Martin Klapetek.
> 
> 
> Description
> -------
> 
>     Create and cache the contact groups
>     
>     Earlier, if a group contained more than one contact then it the contact
>     group was created that many times cause a new SimpleResource was created
>     each time.
>     
>     With this method we cache the contact groups so that they are only
>     created once, and once they have been created we do not unnecessarily
>     send a new SimpleResource to get merged into the existing contact group.
> 
> 
> Diffs
> -----
> 
>   nepomuk-storage.h ad5b6bc 
>   nepomuk-storage.cpp adee609 
> 
> Diff: http://git.reviewboard.kde.org/r/110739/diff/
> 
> 
> Testing
> -------
> 
> No more duplicate contact groups.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130922/76389f37/attachment-0001.html>


More information about the KDE-Telepathy mailing list