Review Request 112875: Use presence same as request presence as current presence

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112875/#review40435
-----------------------------------------------------------


The bug you're linking to is marked as resolved so what are we fixing here?

There are two things that I think are going to cause problems:
 - One of the motivations for using requestedPresence was otherwise you could select something from the drop down menu and nothing would happen.

 - If I run "mc-tool request /someAccount offline". I would be marked as all offline, which is obviously not right.
I know per account presences is sort of broken regardless (I need someone to fix the KDED module) but I don't want to make it worse.


Note: Whatever you change in the presence applet, the contact applet also MUST match. 


- David Edmundson


On Sept. 21, 2013, 9:36 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112875/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2013, 9:36 p.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Description
> -------
> 
> This is related to https://bugs.kde.org/show_bug.cgi?id=302508
> http://commits.kde.org/telepathy-contact-applet/3b7a541d1ef8634b336ba9bd64a70dc4cc7027c3
> 
> The presence in applet is quite inaccurate when using requestedPresence as its icon, while the problem is, if one of account doesn't support part of presence which presence should be current presence.
> 
> IMHO a better solution is to let currentPresence to be the one same as global requested presence. So no matter in what case, the presence applet can show a presence which an account actually is.
> 
> If this passes the review I'd like to revert http://commits.kde.org/telepathy-contact-applet/3b7a541d1ef8634b336ba9bd64a70dc4cc7027c3 .
> 
> 
> This addresses bug 302508.
>     http://bugs.kde.org/show_bug.cgi?id=302508
> 
> 
> Diffs
> -----
> 
>   KTp/global-presence.cpp 8e88be9 
> 
> Diff: http://git.reviewboard.kde.org/r/112875/diff/
> 
> 
> Testing
> -------
> 
> installed sault as the report, set to invisible, currentPresence is busy (I have another gmail account supports hidden).
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130921/49deda6f/attachment.html>