Review Request 112704: Set presence shouldn't depends on isOnline

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112704/
-----------------------------------------------------------

(Updated Sept. 21, 2013, 8:52 p.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

updated, see new description.


Summary (updated)
-----------------

Set presence shouldn't depends on isOnline


Description
-------

Some discussion in this thread: http://mail.kde.org/pipermail/kde-telepathy/2013-September/009951.html

This patch will listen on onlinenessChange and setRequestPresence to account when account back online.


Diffs (updated)
-----

  telepathy-module.h f39e006 
  telepathy-module.cpp 57904b2 

Diff: http://git.reviewboard.kde.org/r/112704/diff/


Testing
-------

add an account with wrong password. lock screen, bad account still offline and no dialog popup.
suspend and relogin, account doesn't keep always away.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130921/b8adbd3b/attachment-0001.html>